Talk:Greeting.javaFrom WikiJavaComments on Greeting.java <comments /> Variable names and While loopsComments and importNice :) It remembers me my very old days (actually 24 years ago) writing BASIC code on my C64 :P I usually prefer to import just the right class, and avoid the .* import. Anyway I think there are some good points in this class. --Alcor 11:46, 17 September 2008 (PDT) |

Thanks for sharing, I modified the names of your variables, it is good practice to avoid short names and acronyms. The results are more legible.
I also deleted the ifs using instead a while. There's no duplicate code now and the while prevents the Strings to be empty.
--DonGiulio 08:54, 17 September 2008 (PDT)